Support private key JWT token endpoint authentication #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricklambrechts
changed the title
gerbrand-bosch
previously approved these changes
Jun 7, 2024
annejan
previously approved these changes
Jun 7, 2024
Used the same jti implementation as jumbojett/OpenID-Connect-PHP
ricklambrechts
dismissed stale reviews from annejan and gerbrand-bosch
via
5732ef3
ricklambrechts
force-pushed
the
add_private_key_jwt_support
branch
from
a38a220
to
0b0e52d
Compare
gerbrand-bosch
previously approved these changes
Jun 7, 2024
gerbrand-bosch
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
According to spec https://openid.net/specs/openid-connect-core-1_0-errata2.html#ClientAuthentication.
For the JTI claim I used the same implementation as the OpenID Connect PHP package.
https://github.com/jumbojett/OpenID-Connect-PHP/blob/1a468a40175e6d3366328678309623985ca2b150/src/OpenIDConnectClient.php#L1929