Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TypeScript support #631

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: Add TypeScript support #631

wants to merge 1 commit into from

Conversation

yenshih
Copy link
Contributor

@yenshih yenshih commented Jun 12, 2019

相关 ISSUE: (ISSUE 链接地址)

1、升级点 (清晰准确的描述升级的功能点)

2、影响范围 (描述该需求上线会影响什么功能)

3、自测 Checklist

4、需要覆盖的场景和 Case

  • 是否覆盖了 sf 打开 MIP 页
  • 是否验证了极速服务 MIP 页面效果

5、自测机型和浏览器

  • 是否覆盖了 iOS 系统手机
  • 是否覆盖了 Android 系统手机
  • 是否覆盖了 iPhone 版式浏览器(比如 QQ、UC、Chrome、Safari、安卓自带浏览器)
  • 是否覆盖了手百

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1237

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 94.436%

Files with Coverage Reduction New Missed Lines %
src/page/index.js 5 93.41%
Totals Coverage Status
Change from base Build 1234: -0.002%
Covered Lines: 3890
Relevant Lines: 4030

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1269

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 94.436%

Files with Coverage Reduction New Missed Lines %
src/page/index.js 5 93.41%
Totals Coverage Status
Change from base Build 1234: -0.002%
Covered Lines: 3890
Relevant Lines: 4030

💛 - Coveralls

@mipengine-bot
Copy link
Member

This pull request fixes 1 alert when merging bcef2f4 into 838bac2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.


Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants