-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jon/feature/auto sweep #174
Conversation
Codecov Report
@@ Coverage Diff @@
## development #174 +/- ##
===============================================
+ Coverage 60.38% 60.64% +0.26%
===============================================
Files 35 35
Lines 7830 7897 +67
===============================================
+ Hits 4728 4789 +61
- Misses 3102 3108 +6
Continue to review full report at Codecov.
|
Penny for your thoughts on the comments above, but otherwise, looks good! Appreciate you keeping everyone Pep8-honest as always. This also might be a good PR to squash when you merge since it very tidily adds one feature. |
These changes automatically set the "sweep" value during the construction of atomic environments; this allows the user to choose any cutoff radius, regardless of the size of the structure. This is expected to be useful for small non-cubic structures, where it's not obvious a priori how large the supercell should be when constructing environments.