Steven/feature/gp write choice #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nw13slx
approved these changes
Jun 19, 2020
| @@ -670,20 +673,24 @@ def from_dict(dictionary): | |||
| new_gp.n_envs_prev = len(new_gp.training_data) | |||
|
|
|||
| # Save time by attempting to load in computed attributes | |||
| if len(new_gp.training_data) > 5000: | |||
There was a problem hiding this comment.
thanks for removing this arbitrary criteria
| @@ -670,20 +673,24 @@ def from_dict(dictionary): | |||
| new_gp.n_envs_prev = len(new_gp.training_data) | |||
|
|
|||
| # Save time by attempting to load in computed attributes | |||
| if len(new_gp.training_data) > 5000: | |||
| if dictionary.get('ky_mat_file'): | |||
There was a problem hiding this comment.
maybe next time this part can be written as a function? it repeats again in the from_dict method.
| @@ -829,21 +855,35 @@ def write_model(self, name: str, format: str = 'json'): | |||
| self.alpha = None | |||
| self.ky_mat_inv = None | |||
|
|
|||
| # Automatically detect output format from name variable | |||
|
|
|||
| for detect in ['json','pickle','binary']: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes:
GaussianProcess.write_modelnow allows for flexibility for the user to decide if they want the matrices written separately or not.write_modelnow will not redundantly append .json or .pickle to written models. If the file name ismy_model.jsonthen it will not writemy_model.json.json. Also, if you don't specify the format, but if you specify it in the string, it automatically detects it. A small friction I've encountered!