Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Add backwards compatibility for pickled envs #189

Merged
merged 4 commits into from
Jun 23, 2020

Conversation

stevetorr
Copy link
Contributor

@stevetorr stevetorr commented Jun 19, 2020

  • env.py should now be backwards compatible with old atomic environment objects without a cutoffs mask attribute
  • Clean up PEP8 compliance for env.py and test_env.py

@stevetorr stevetorr changed the title Add backwards compatibility for pickled envs [WIP]Add backwards compatibility for pickled envs Jun 19, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #189 into development will increase coverage by 0.01%.
The diff coverage is 96.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #189      +/-   ##
===============================================
+ Coverage        60.90%   60.91%   +0.01%     
===============================================
  Files               44       44              
  Lines             8252     8257       +5     
===============================================
+ Hits              5026     5030       +4     
- Misses            3226     3227       +1     
Impacted Files Coverage Δ
flare/env.py 98.43% <96.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb39b76...9357cad. Read the comment docs.

@stevetorr stevetorr merged commit 83f0b5c into development Jun 23, 2020
@stevetorr stevetorr deleted the steven/bugfix/backwardscompatenv branch August 6, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants