Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steven/bugfix/mgp predict #192

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Steven/bugfix/mgp predict #192

merged 6 commits into from
Jun 24, 2020

Conversation

stevetorr
Copy link
Contributor

If an MGP is unpickled and used, routines called within the https://github.com/mir-group/flare/blob/development/flare/mgp/cubic_splines_numba.py cubic splines numba file will attempt to use a variable dAd which is only defined when filter_coeffs is called, which seems to only occur during mapping. This adds a call to the calculate_coeffs function when the cubic_splines_numba file is imported, loading it into global memory.

@stevetorr stevetorr requested a review from YuuuXie June 24, 2020 06:30
@codecov-commenter
Copy link

Codecov Report

Merging #192 into development will increase coverage by 1.95%.
The diff coverage is 2.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #192      +/-   ##
===============================================
+ Coverage        60.89%   62.85%   +1.95%     
===============================================
  Files               44       44              
  Lines             8263     8672     +409     
===============================================
+ Hits              5032     5451     +419     
+ Misses            3231     3221      -10     
Impacted Files Coverage Δ
flare/env.py 98.42% <ø> (+1.55%) ⬆️
flare/gp.py 89.95% <ø> (-0.03%) ⬇️
flare/mgp/cubic_splines_numba.py 7.04% <2.85%> (-2.14%) ⬇️
flare/mgp/map3b.py 86.66% <0.00%> (+1.84%) ⬆️
flare/mgp/mgp.py 99.43% <0.00%> (+2.58%) ⬆️
flare/parameters.py 84.69% <0.00%> (+2.80%) ⬆️
flare/utils/parameter_helper.py 92.78% <0.00%> (+6.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72e46c...b42747a. Read the comment docs.

@stevetorr stevetorr merged commit 8726037 into development Jun 24, 2020
@stevetorr stevetorr deleted the steven/bugfix/mgp_predict branch August 6, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants