Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0 Add b1 descriptors: merge to development #350

Merged
merged 11 commits into from
May 4, 2023
Merged

Conversation

YuuuXie
Copy link
Collaborator

@YuuuXie YuuuXie commented Apr 19, 2023

Add b1 descriptors: only the descriptors code for sparse GP (b1.cpp, b1.h) and c++ unit test (test_descriptors.cpp), not including lammps related code

@YuuuXie YuuuXie requested review from anjohan and cjowen1 April 19, 2023 22:49
Copy link
Collaborator

@cjowen1 cjowen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that the cpp files were copied and modified from pre-existing B2, and the additions to call B1 all look fine.

@YuuuXie YuuuXie merged commit af8be62 into development May 4, 2023
@YuuuXie YuuuXie deleted the feature/yu/b1 branch May 4, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants