Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach all losses that get saved #1

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Detach all losses that get saved #1

merged 3 commits into from
Mar 17, 2021

Conversation

Linux-cpp-lisp
Copy link
Collaborator

No description provided.

@Linux-cpp-lisp Linux-cpp-lisp marked this pull request as draft March 17, 2021 20:07
nequip/train/trainer.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@nw13slx nw13slx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just please run with all unit tests to double check

nequip/train/trainer.py Outdated Show resolved Hide resolved
@Linux-cpp-lisp
Copy link
Collaborator Author

All tests pass; minimal.yaml runs to decent error.

@Linux-cpp-lisp Linux-cpp-lisp marked this pull request as ready for review March 17, 2021 21:24
@Linux-cpp-lisp Linux-cpp-lisp merged commit 73bd958 into main Mar 17, 2021
@Linux-cpp-lisp Linux-cpp-lisp deleted the alby/no-grad-loss branch March 17, 2021 23:47
Linux-cpp-lisp added a commit that referenced this pull request Apr 30, 2024
---------

Co-authored-by: Linux-cpp-lisp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants