Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency com.approvaltests:approvaltests to v22 #210

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 12, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.approvaltests:approvaltests (source) 18.7.1 -> 22.3.3 age adoption passing confidence

Release Notes

approvals/ApprovalTests.Java (com.approvaltests:approvaltests)

v22.3.3: Updating dependency to jakarta mail

Compare Source

Closes issue #​376

v22.3.2: Inline reporter detects expected

Compare Source

Fixes a minor bug where you have code before expected for inline approvals

v22.3.1: InlineJavaReporter uses tab/spaces

Compare Source

v22.3.0: inline Approvals

Compare Source

https://github.com/approvals/ApprovalTests.Java/blob/master/approvaltests/docs/how_to/InlineApprovals.md

https://github.com/approvals/ApprovalTests.Java/blob/master/approvaltests/docs/explanations/InlineApprovalsWorkflow.md

v22.2.1: TestUtils.displayFile fixed on MacOS

Compare Source

as reported in #​429

v22.2.0: IntellijReporter support for Windows

Compare Source

when installed via Jetbrains Toolbox

v22.1.0: IntellijReporter support for Linux

Compare Source

must be installed via toolbox!

v22.0.0: Remove deprecated api

Compare Source

Minor breaking changes

Issue #​376 made javax.mail optional
Removed deprecated api in JupiterApprovals
Moved TestUtils.displayEmail to EmailOpener.displayEmail

v21.2.0: Easy reordering of JSON for consistent approvals

Compare Source

The Problem:

JSON does not define an order to the fields.
This can make approving JSON inconsistent as ApprovalTests requires consistent results.

The Solution:

JsonApprovals.verifyJson(json) now has an overload:
JsonApprovals.verifyJson(json, reorderJson: true)
which will alphabetically sort the JSON in the result.
By default it still does not reorder the JSON.

Extras

You can call the reordering directly with
JsonUtils.reorderFields(json)
This fixes #​422

v21.1.0: Improvements for IntelliJ reporters when using Jetbrains Toolbox

Compare Source

On Mac, when using Jetbrains Toolbox, we now should detect your IntelliJ installation and launch the idea diff viewer.

v21.0.0: Fixes to KDiff3

Compare Source

Added KDiff3 Linux reporter.
Minor breaking changes
KDiff3Reporter has been moved to KDiff3MacReporter, KDiff3WindowsReporter as appropriate.
We also created a generic KDiff3 reporter that will work on all three systems.
Closes issue #​412

v20.0.0: Removal of EnvironmentAwareReporter

Compare Source

This is a breaking change.

When you call Reporter.report(received, approved) it now returns if it was successful.
This makes the java architecture more consistent with other implementations and allows us to determine when something should have worked but it didn't.

It should not affect you unless you've written a custom implementation of ApprovalFailureReporter.

Information on why and how to upgrade can be found here.

v19.0.0: Exceptions and Help messages on duplicate verify() calls.

Compare Source

ApprovalTests only wants one call to verify() per test.
There are ways to go around this but if you call verify where it would want the exact same file name twice, it will now throw an exception.
This will make it easier for people to not be confused as most other testing frameworks allow you to put multiple assertions in the same test.

Backwards compatibility

There are some situations where you want to check that two different processes produce the same result.
Calling verify multiple times in the same test can be a way to do this.
If you want to do that, we have provided two calls:

  • Approvals.settings().allowMultipleVerifyCallsForThisClass()
  • Approvals.settings().allowMultipleVerifyCallsForThisMethod()

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 18 0 0.34s
✅ BASH bash-exec 4 0 0.09s
✅ BASH shellcheck 1 0 0.05s
✅ BASH shfmt 4 0 0.04s
✅ CSHARP csharpier 1 0 1.22s
⚠️ CSHARP dotnet-format 1 1 2.2s
⚠️ CSHARP roslynator 1 1 8.61s
✅ CSS stylelint 1 0 1.14s
✅ DOCKERFILE hadolint 4 0 0.2s
✅ EDITORCONFIG editorconfig-checker 374 0 3.63s
✅ ENV dotenv-linter 1 0 0.01s
✅ GROOVY npm-groovy-lint 7 0 13.45s
✅ HTML djlint 2 0 0.92s
✅ HTML htmlhint 2 0 0.31s
✅ JAVA checkstyle 59 0 8.06s
✅ JSON eslint-plugin-jsonc 29 0 6.92s
✅ JSON jsonlint 29 0 0.4s
⚠️ JSON prettier 29 1 4.98s
✅ JSON v8r 29 0 61.76s
⚠️ MARKDOWN markdownlint 22 132 1.69s
✅ PYTHON bandit 1 0 0.84s
✅ PYTHON black 1 0 0.79s
✅ PYTHON flake8 1 0 0.42s
✅ PYTHON isort 1 0 0.26s
✅ PYTHON mypy 1 0 6.91s
✅ PYTHON ruff 1 0 0.02s
✅ REPOSITORY checkov yes no 30.18s
✅ REPOSITORY gitleaks yes no 1.7s
✅ REPOSITORY git_diff yes no 0.14s
✅ REPOSITORY grype yes no 21.47s
✅ REPOSITORY kics yes no 65.45s
✅ REPOSITORY secretlint yes no 2.48s
✅ REPOSITORY syft yes no 1.42s
✅ REPOSITORY trivy yes no 21.83s
✅ REPOSITORY trivy-sbom yes no 9.5s
✅ REPOSITORY trufflehog yes no 6.85s
✅ SQL sql-lint 2 0 0.87s
✅ XML xmllint 3 0 0.01s
✅ YAML prettier 109 0 1.94s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@chgl chgl merged commit b1dcf4d into master Jan 12, 2024
25 checks passed
This was referenced Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant