Some more migration tests #2113
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 64.79% 64.83% +0.03%
==========================================
Files 133 133
Lines 15851 15881 +30
==========================================
+ Hits 10271 10296 +25
- Misses 5580 5585 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
icristescu
force-pushed
the
upgrade_tests
branch
from
a94a148
to
27f165e
Compare
test/irmin-pack/test_upgrade.ml
Outdated
| @@ -86,7 +90,7 @@ let key_of_entry x = | |||
| type start_mode = From_v2 | From_v3 | From_scratch [@@deriving irmin] | |||
|
|
|||
| type setup = { | |||
| indexing_strategy : [ `always | `minimal ]; | |||
| indexing_strategy : [ `always | `minimal | `minimal_gc ]; | |||
There was a problem hiding this comment.
minimal_gc is not an indexing strategy 😛
If I understand correctly archive_v3_minimal_gced is a store where a GC was run targeting c0.
I suggest you alter start_mode instead of indexing_strategy. You could name the new tag something like From_v3_c0_gced.
There was a problem hiding this comment.
That's better, done
|
Can you update https://github.com/tarides/irmin-scratch/tree/main/scripts/pr1892 accordingly? |
icristescu
force-pushed
the
upgrade_tests
branch
from
27f165e
to
699da5d
Compare
This PR adds a V3 store that underwent a Gc to the upgrade tests. I will add two additional stores (V4 and V4 after gc) to these tests once we have the chunk files. Apart from that, I don't see any other migration tests, but happy to do add more if anyone has other ideas.
Rebased on #2110.