Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: add classification for volume files #2201

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

metanivek
Copy link
Member

As pointed out in #2197, we need classification for volumes. So this PR does that. 😎

@metanivek metanivek added the no-changelog-needed No changelog is needed here label Feb 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2201 (cbea0b2) into main (fc9d3cb) will increase coverage by 0.03%.
The diff coverage is 92.30%.

❗ Current head cbea0b2 differs from pull request most recent head b91dfe5. Consider uploading reports for the commit b91dfe5 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2201      +/-   ##
==========================================
+ Coverage   67.97%   68.01%   +0.03%     
==========================================
  Files         135      135              
  Lines       16301    16302       +1     
==========================================
+ Hits        11081    11088       +7     
+ Misses       5220     5214       -6     
Impacted Files Coverage Δ
src/irmin-pack/unix/file_manager.ml 83.86% <60.00%> (ø)
src/irmin-pack/layout.ml 83.63% <100.00%> (+0.30%) ⬆️
src/irmin-fs/unix/irmin_fs_unix.ml 68.38% <0.00%> (+3.87%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@clecat clecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx a lot

@metanivek metanivek merged commit eddf517 into mirage:main Feb 27, 2023
@metanivek metanivek deleted the classify_volumes branch February 27, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed No changelog is needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants