Search for TLS trust anchors lazily #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the type of `Conduit_lwt_tls.X509.default_authenticator` and `Conduit_lwt_unix.default_ctx` to be lazy, avoiding various side-effects (system interactions, logging) due to constructing these values at initialisation time. Fixes mirage#388.
|
This'll require a corresponding PR in cohttp-lwt to do the Lazy.force, and then both can be released together. |
Merged
hannesm
added a commit
to hannesm/ocaml-conduit
that referenced
this pull request
Oct 8, 2021
this fixes compilation without the tls library (improving mirage#395 @craigfe)
hannesm
added a commit
to hannesm/ocaml-conduit
that referenced
this pull request
Oct 9, 2021
this fixes compilation without the tls library (improving mirage#395 @craigfe)
hannesm
added a commit
to hannesm/ocaml-conduit
that referenced
this pull request
Oct 18, 2021
this fixes compilation without the tls library (improving mirage#395 @craigfe)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 20, 2021
…and conduit-async (5.0.0) CHANGES: * change the type of `Conduit_lwt_tls.X509.default_authenticator` and `Conduit_lwt_unix.default_ctx` to be lazy, avoiding various side-effects (system interactions, logging) due to constructing these values at initialisation time. (@craigfe, mirage/ocaml-conduit#395 mirage/ocaml-conduit#404) * Adapt conduit-mirage to dns-client 6.0.0 API (mirage/ocaml-conduit#406 @hannesm) * Use Lwt.pause instead of Lwt_unix.yield (mirage/ocaml-conduit#403 @MisterDA) * Avoid deprecated Fmt.kstrf (mirage/ocaml-conduit#407 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the type of
Conduit_lwt_tls.X509.default_authenticatorandConduit_lwt_unix.default_ctxto be lazy, avoiding various side-effects (system interactions, logging) due to constructing these values at initialisation time.Fixes #388.