Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 16-byte string for internal representation of IPv6 addresses #16

Closed
dsheets opened this issue Jan 16, 2014 · 1 comment · Fixed by ocaml/opam-repository#23504
Closed

Use 16-byte string for internal representation of IPv6 addresses #16

dsheets opened this issue Jan 16, 2014 · 1 comment · Fixed by ocaml/opam-repository#23504
Labels
enhancement

Comments

@dsheets
Copy link
Member

dsheets commented Jan 16, 2014

A bytestring will be cheaper than a quad of int32s (2 indirections, 5 extra boxes).
@verbosemode verbosemode mentioned this issue Feb 14, 2023
Closed
verbosemode added a commit to verbosemode/ocaml-ipaddr that referenced this issue Mar 9, 2023
@verbosemode
use Bytes.t as data type for IPv6 addresses
85785b3 
* this addresses issue mirage#16
@verbosemode verbosemode mentioned this issue Mar 9, 2023
Merged
verbosemode added a commit to verbosemode/ocaml-ipaddr that referenced this issue Mar 10, 2023
@verbosemode
use Bytes.t as data type for IPv6 addresses
bf9ebb6 
* this addresses issue mirage#16
@hannesm
Copy link
Member

hannesm commented Mar 13, 2023

fixed by #115

@hannesm hannesm closed this as completed Mar 13, 2023
@hannesm hannesm mentioned this issue Mar 13, 2023
Merged
hannesm added a commit to hannesm/opam-repository that referenced this issue Mar 13, 2023
@hannesm
[new release] macaddr, macaddr-sexp, macaddr-cstruct, ipaddr, ipaddr-…
8b6e25d 
…sexp and ipaddr-cstruct (5.4.0)

CHANGES:

* Use Bytes.t for IPv6 addresses (mirage/ocaml-ipaddr#115 @verbosemode, fixes mirage/ocaml-ipaddr#16 @dsheets)
* Also fixes V6.to_int64 (reported by @RyanGibb in mirage/ocaml-ipaddr#113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@dsheets @hannesm