-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tar.Header.Header.unmarshal should treat Normal
entries with trailing slash name as Directory
.
#129
Comments
Thanks, I was not aware. How do you think we should handle this? There's the For the latter two it makes sense to consider this when extracting. In #127 I'm reworking For I am curious if you know how to create such an archive, or if you have a (small) sample. |
You can create such archives with I would implement that
in |
I was curious how gnu tar would treat a tar archive with a pax header setting the file name to $ tar -tvf pax-shenanigans.tar
dr-------- 0/0 0 1970-01-01 01:00 clearly/a/directory/ Here's the sample archive (gzipped so github accepts it) pax-shenanigans.tar.gz I will make a PR shortly implementing your second proposal. |
CHANGES: - Treat headers with link indicator '0' or '\000' (`Normal`) as directories for backward compatibility (reported in mirage/ocaml-tar#129, fix by @reynir)
tar.2.5.1 has been submitted to opam-repository with a fix. Thank you for the report and the discussion on how to fix it. |
CHANGES: - Treat headers with link indicator '0' or '\000' (`Normal`) as directories for backward compatibility (reported in mirage/ocaml-tar#129, fix by @reynir)
It seems that I was wrong: the fix up for And I encountered archive (which unfortunately I can't provide) there |
This is how I fixed the issue locally (probably missed a couple of other issues):
|
reopening, thanks for your testing and reporting! |
Dear @gravicappa, thank you for your report and for sharing your own fix, and sorry for not reacting earlier. Unfortunately |
CHANGES: - Add eio backend for tar in `tar-eio` (@patricoferris, review by @talex5, @reynir, mirage/ocaml-tar#132) - Also apply backwards compatibility fix when GNU LongName is used. The compatibility fix is unfortunately also applied for unknown-to-ocaml-tar link indicators (reported by @gravicappa in mirage/ocaml-tar#129, @reynir, mirage/ocaml-tar#133)
A fix's released in 2.6.0. I will keep this issue open until I have a fix for the |
Done in #127 |
CHANGES: - Add eio backend for tar in `tar-eio` (@patricoferris, review by @talex5, @reynir, mirage/ocaml-tar#132) - Also apply backwards compatibility fix when GNU LongName is used. The compatibility fix is unfortunately also applied for unknown-to-ocaml-tar link indicators (reported by @gravicappa in mirage/ocaml-tar#129, @reynir, mirage/ocaml-tar#133)
As written here.
And I have encountered archives like that.
The text was updated successfully, but these errors were encountered: