[closes #167] allow ids of 0

miragejs · Jun 10, 2015 · 8d57d81 · 8d57d81
1 parent a806df9
commit 8d57d81
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/addon/db.js b/addon/db.js
@@ -52,7 +52,7 @@ export default function() {
 
     if (!Ember.isArray(copy)) {
       var attrs = copy;
-      if (!attrs.id) {
+      if (attrs.id === undefined || attrs.id === null) {
         attrs.id = _this[collection].length + 1;
       }
 
@@ -62,7 +62,7 @@ export default function() {
     } else {
       returnData = [];
       copy.forEach(function(attrs) {
-        if (!attrs.id) {
+        if (attrs.id === undefined || attrs.id === null) {
           attrs.id = _this[collection].length + 1;
         }
 

diff --git a/tests/unit/db-test.js b/tests/unit/db-test.js
@@ -99,6 +99,12 @@ test('it does not add ids to array data if present', function(assert) {
   assert.deepEqual(db.contacts, [{id: 2, name: 'Link'}, {id: 1, name: 'Ganon'}]);
 });
 
+test('it can insert a record with an id of 0', function(assert) {
+  db.contacts.insert({id: 0, name: 'Link'});
+
+  assert.deepEqual(db.contacts, [{id: 0, name: 'Link'}]);
+});
+
 
 module('mirage:db#find', {
   beforeEach: function() {