Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove b2a dependency #7

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Remove b2a dependency #7

merged 2 commits into from
Aug 5, 2020

Conversation

jneurock
Copy link
Collaborator

@jneurock jneurock commented Aug 5, 2020

This PR removes the b2a dependency. There seems to be some problem with loading this dependency if Mirage GraphQL is imported in Mirage's REPL. Instead, we assume the code is running in the browser or Node.

The b2a library was only used in one place when creating opaque Relay pagination node IDs. If all else fails, default encoding falls back to a passthrough function.

@jneurock jneurock merged commit 3032b97 into main Aug 5, 2020
@jneurock jneurock deleted the remove-b2a-dependency branch August 5, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant