Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#395 Perform stack allocation for non escaping objects #397

Merged
merged 14 commits into from
May 9, 2020
Merged

#395 Perform stack allocation for non escaping objects #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1af46cb
#395 Perform stack allocation for non escaping objects
mirkosertic May 6, 2020
77807de
#395 Perform stack allocation for non escaping objects
mirkosertic May 6, 2020
66d5f8e
#395 Perform stack allocation for non escaping objects
mirkosertic May 6, 2020
c50756b
#395 Perform stack allocation for non escaping objects
mirkosertic May 6, 2020
5c8d8d8
#395 Perform stack allocation for non escaping objects
mirkosertic May 6, 2020
d36c11b
#395 Perform stack allocation for non escaping objects
mirkosertic May 6, 2020
3535a4d
Optimized Disk Usage
mirkosertic May 7, 2020
1f5f725
More meaningful intrinsic names
mirkosertic May 7, 2020
93919e8
Escape by constructor argument
mirkosertic May 7, 2020
b963ba2
#395 Perform stack allocation for non escaping objects
mirkosertic May 8, 2020
b0f479a
#395 Perform stack allocation for non escaping objects
mirkosertic May 8, 2020
4a530f6
#395 Perform stack allocation for non escaping objects
mirkosertic May 8, 2020
e1debc9
#395 Perform stack allocation for non escaping objects
mirkosertic May 8, 2020
9c5537a
#395 Perform stack allocation for non escaping objects
mirkosertic May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
498 changes: 270 additions & 228 deletions core/src/main/java/de/mirkosertic/bytecoder/backend/llvm/LLVMCompilerBackend.java
View file
Open in desktop

Large diffs are not rendered by default.

82 changes: 58 additions & 24 deletions core/src/main/java/de/mirkosertic/bytecoder/backend/llvm/LLVMWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public class LLVMWriter implements AutoCloseable {
public static final String CLASSINITSUFFIX = "__init";
public static final String VTABLESUFFIX = "__vtable";
public static final String VTABLETYPESUFFIX = "__vtable__type";
public static final String NEWINSTANCEHELPER = "newinstancehelper";
public static final String NEWINSTANCEHELPER = "bytecoder.newinstancehelper";
public static final String INTERFACEDISPATCHSUFFIX = "__interfacedispatch";

interface SymbolResolver {
Expand Down Expand Up @@ -1034,7 +1034,7 @@ private void write(final TableSwitchExpression e) {

target.print(" %");
target.print(toTempSymbol(e, "cond"));
target.print(" = call i1 @exceedsrange(i32 %");
target.print(" = call i1 @bytecoder.exceedsrange(i32 %");
target.print(toTempSymbol(e, "value"));
target.print(", i32 ");
target.print(e.getLowValue());
Expand Down Expand Up @@ -1143,6 +1143,16 @@ private void write(final NewArrayExpression e) {
target.print(toTempSymbol(e, "vtable"));
target.print(")");
currentSubProgram.writeDebugSuffixFor(e, target);

if (e.isEscaping()) {
linkerContext.getStatistics().context("Codegenerator")
.counter("ArrayOnHeapAllocations").increment();
} else {
linkerContext.getStatistics().context("Codegenerator")
.counter("ArrayOnStackAllocations").increment();

target.print(";; might be a stack allocation here. Please verify.");
}
}

private void write(final ThrowExpression e) {
Expand Down Expand Up @@ -1732,6 +1742,16 @@ private void write(final NewMultiArrayExpression e) {
target.write(toTempSymbol(e, "vtable"));
target.write(")");
currentSubProgram.writeDebugSuffixFor(e, target);

if (e.isEscaping()) {
linkerContext.getStatistics().context("Codegenerator")
.counter("MultiArrayOnHeapAllocations").increment();
} else {
linkerContext.getStatistics().context("Codegenerator")
.counter("MultiArrayOnStackAllocations").increment();

target.print(";; might be a stack allocation here. Please verify.");
}
}

private void write(final SqrtExpression e) {
Expand All @@ -1751,7 +1771,7 @@ private void write(final MethodTypeArgumentCheckExpression e) {
final Value theMethodType = e.incomingDataFlows().get(0);
final Value theIndex = e.incomingDataFlows().get(1);

target.print("call i32 @checkmethodtype(i32 ");
target.print("call i32 @bytecoder.checkmethodtype(i32 ");
write(theMethodType, true);
target.print(", i32 ");
write(theIndex, true);
Expand All @@ -1766,7 +1786,7 @@ private void write(final EnumConstantsExpression e) {
}

private void write(final LambdaWithStaticImplExpression e) {
target.print("call i32 @newLambdaImpl(i32 ");
target.print("call i32 @bytecoder.newLambda(i32 ");
write(e.getType(), true);
target.print(",i32 ");
write(e.getStaticRef(), true);
Expand All @@ -1776,7 +1796,7 @@ private void write(final LambdaWithStaticImplExpression e) {
}

private void write(final LambdaConstructorReferenceExpression e) {
target.print("call i32 @newLambdaImpl(i32 ");
target.print("call i32 @bytecoder.newLambda(i32 ");
write(e.getType(), true);
target.print(",i32 ");
write(e.getConstructorRef(), true);
Expand All @@ -1786,7 +1806,7 @@ private void write(final LambdaConstructorReferenceExpression e) {
}

private void write(final LambdaInterfaceReferenceExpression e) {
target.print("call i32 @newLambdaImpl(i32 ");
target.print("call i32 @bytecoder.newLambda(i32 ");
write(e.getType(), true);
target.print(",i32 ");
write(e.getInterfaceRef(), true);
Expand All @@ -1796,7 +1816,7 @@ private void write(final LambdaInterfaceReferenceExpression e) {
}

private void write(final LambdaVirtualReferenceExpression e) {
target.print("call i32 @newLambdaImpl(i32 ");
target.print("call i32 @bytecoder.newLambda(i32 ");
write(e.getType(), true);
target.print(",i32 ");
write(e.getVirtualRef(), true);
Expand All @@ -1806,7 +1826,7 @@ private void write(final LambdaVirtualReferenceExpression e) {
}

private void write(final LambdaSpecialReferenceExpression e) {
target.print("call i32 @newLambdaImpl(i32 ");
target.print("call i32 @bytecoder.newLambda(i32 ");
write(e.getType(), true);
target.print(",i32 ");
write(e.getSpecialRef(), true);
Expand All @@ -1827,10 +1847,10 @@ private void write(final MaxExpression e) {
target.print(" @llvm.maximum.f32");
break;
case LONG:
target.print(" @maximum.i64");
target.print(" @bytecoder.maximum.i64");
break;
default:
target.print(" @maximum");
target.print(" @bytecoder.maximum.i32");
break;
}
target.print("(");
Expand Down Expand Up @@ -1896,13 +1916,13 @@ private void write(final DoubleValue e) {
private void write(final IsNaNExpression e) {
final Value theValue = e.incomingDataFlows().get(0);
if (theValue.resolveType().resolve() == TypeRef.Native.DOUBLE) {
target.print("call i32 @isnanDouble(");
target.print("call i32 @bytecoder.isnan.double(");
target.print(LLVMWriterUtils.toType(theValue.resolveType()));
target.print(" ");
writeResolved(theValue);
target.print(")");
} else {
target.print("call i32 @isnan(");
target.print("call i32 @bytecoder.isnan.float(");
target.print(LLVMWriterUtils.toType(theValue.resolveType()));
target.print(" ");
writeResolved(theValue);
Expand All @@ -1926,10 +1946,10 @@ private void write(final MinExpression e) {
target.print(" @llvm.minimum.f32");
break;
case LONG:
target.print(" @minimum.i64");
target.print(" @bytecoder.minimum.i64");
break;
default:
target.print(" @minimum");
target.print(" @bytecoder.minimum.i32");
break;
}
target.print("(");
Expand Down Expand Up @@ -2016,10 +2036,10 @@ private void write(final CompareExpression e) {
switch (theValue1Type) {
case FLOAT:
case DOUBLE:
target.print("call i32 @compare_f32(");
target.print("call i32 @bytecoder.compare.float(");
break;
default:
target.print("call i32 @compare_i32(");
target.print("call i32 @bytecoder.compare.i32(");
break;
}
target.print(LLVMWriterUtils.toType(theValue1.resolveType()));
Expand Down Expand Up @@ -2052,7 +2072,7 @@ private void write(final NewObjectExpression e) {
}

private void write(final InstanceOfExpression e) {
target.print("call i32 @instanceof(i32 ");
target.print("call i32 @bytecoder.instanceof(i32 ");
writeResolved(e.incomingDataFlows().get(0));
target.print(",i32 ");
final BytecodeLinkedClass theLinkedClass = linkerContext.resolveClass(BytecodeObjectTypeRef.fromUtf8Constant(e.getType().getConstant()));
Expand Down Expand Up @@ -2152,22 +2172,36 @@ private void write(final GetFieldExpression e) {
}

private void write(final NewObjectAndConstructExpression e) {

if (e.isEscaping()) {
linkerContext.getStatistics().context("Codegenerator")
.counter("ObjectOnHeapAllocations").increment();
} else {
linkerContext.getStatistics().context("Codegenerator")
.counter("ObjectOnStackAllocations").increment();
}

target.print("call i32 (i32");
for (int i=0;i<e.getSignature().getArguments().length;i++) {
for (int i = 0; i < e.getSignature().getArguments().length; i++) {
target.print(",");
target.print(LLVMWriterUtils.toType(TypeRef.toType(e.getSignature().getArguments()[i])));
}
target.print(") @");
target.print(LLVMWriterUtils.toMethodName(e.getClazz(), LLVMWriter.NEWINSTANCE_METHOD_NAME, e.getSignature()));
target.print("(i32 %");
target.print(LLVMWriterUtils.runtimeClassVariableName(e.getClazz()));
for (int i=0;i<e.incomingDataFlows().size();i++) {
for (int i = 0; i < e.incomingDataFlows().size(); i++) {
target.print(",");
target.print(LLVMWriterUtils.toType(TypeRef.toType(e.getSignature().getArguments()[i])));
target.print(" ");
writeResolved(e.incomingDataFlows().get(i));
}
target.println(")");

if (e.isEscaping()) {
target.println(")");
} else {
target.println(") ;; might be a stack allocation here. Please verify.");
}
}

private void write(final StackTopExpression e) {
Expand Down Expand Up @@ -2219,7 +2253,7 @@ private void write(final TypeConversionExpression e) {
case LONG: {
// Convert double to i64
// NaN == 0
target.print("call i64 @doubleToi64(double ");
target.print("call i64 @bytecoder.double.to.i64(double ");
writeResolved(theSource);
target.print(")");
return;
Expand All @@ -2230,7 +2264,7 @@ private void write(final TypeConversionExpression e) {
case CHAR: {
// Convert doule to i32
// NaN == 0
target.print("call i32 @doubleToi32(double ");
target.print("call i32 @bytecoder.double.to.i32(double ");
writeResolved(theSource);
target.print(")");
return;
Expand All @@ -2257,7 +2291,7 @@ private void write(final TypeConversionExpression e) {
case LONG: {
// Convert float to i64
// NaN == 0
target.print("call i64 @toi64(float ");
target.print("call i64 @bytecoder.float.to.i64(float ");
writeResolved(theSource);
target.print(")");
return;
Expand All @@ -2268,7 +2302,7 @@ private void write(final TypeConversionExpression e) {
case CHAR: {
// Convert float to i32
// NaN == 0
target.print("call i32 @toi32(float ");
target.print("call i32 @bytecoder.float.to.i32(float ");
writeResolved(theSource);
target.print(")");
return;
Expand Down
Loading