Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove German "Die" and replace with english "the" #909

Merged

Conversation

NoonRightsWarriorBehindHovering
Copy link
Contributor

While evaluating bytecoder i noticed the following simple typos.

Sidenotes:

  1. Any particular reason for JPMS not being supported? I get that the current approach of loading files into the current classpath does not work particular well with this approach, but the maven jars cannot be depended on (e.g to call them in Java without ProcessBuilder). Might be related to 4 as well, given there are a lot of unnecessary dependencies (e.g. Testcontainers or selenium) bundled in the executable and their corresponding Maven artefacts. I would be willing to contribute some changes here too, but we should define the Scope of such changes before any work would just be rejected :).
  2. The documentation seems to be wrong. bytecoderclasses.js or bytecoderruntime.js will be generated. I can contribute fixes to that as well, but i might be wrong.
  3. Is it feasible to implement loading multiple Programms? I mean i could compile them seperately, but downloading the runtime for each is very costly.
  4. Writing or modifying existing ClassLibs seems unsupported or undocumented right now. In particular i would like to be able to override and implement my own Standard Output/Input/Error (System.out/in/err) without the default implementation. I understand being able just use the default Implementations is great and all, but being able to choose, replace or overwrite existing ones would be neat. For example for most Applications there is no need to have 300 lines of code for the Demo Hello World Programm.

@mirkosertic mirkosertic merged commit f9164a1 into mirkosertic:master May 17, 2023
@mirkosertic
Copy link
Owner

mirkosertic commented May 17, 2023

Thank you for your PR!

Regarding:

  1. JPMS is not supported as the generated JVM runtime as a basis for the AOT compiled classes does not support JPMS. There is no module isolation at runtime level, so there is also no module isolation at compile time level.

  2. You are very welcome to provide PRs for additional typos or errors in the documentation :-)

  3. It should be possible to include more than one entry point during compiling and dependency analysis, so the result would be one big JS or WASM file containing different JVM programs.

  4. Indeed, this is undocumented. There are places with a very strong coupling between Java runtime classes and compiler parsing and code generation logic. LambdaMetaFactory and INVOKE DYNAMIC are prominent examples, one more subtle thing that is intrinsified is Class.getEnumConstants(). So sometimes changes in the runtime require also changes at compiler implementation level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants