Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ppx (cstruct and sexplib), removing sexplib converters #473

Merged
merged 7 commits into from
Mar 1, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 22, 2023

see discussion in #472 -- main purpose is to shave the dependency cone (and binary size reduces from 1.3 to 1.0 MB of tls.a)

still open for discussion (feedback, suggestions). will look into CI failures...

@hannesm hannesm merged commit a66fa77 into mirleft:main Mar 1, 2023
@hannesm hannesm deleted the no-ppx-cstruct branch March 1, 2023 12:10
hannesm added a commit to hannesm/opam-repository that referenced this pull request Mar 1, 2023
CHANGES:

* tls-async: remove ocaml < 5.0.0 constraint (mirleft/ocaml-tls#471 mirleft/ocaml-tls#474 @hannesm)
* remove dependency on ppx, especially ppx_cstruct and ppx_sexp_conv across
  the libraries (mirleft/ocaml-tls#473 @hannesm, discussion in mirleft/ocaml-tls#472)
@hannesm
Copy link
Member Author

hannesm commented Mar 1, 2023

failing reverse dependencies:

  • albatross.1.5.6 (failed: Unbound value Tls.Engine.string_of_failure)
  • logs-syslog.0.3.2 (failed: Unbound value Tls.Engine.string_of_failure)
  • conduit-mirage.6.2.0 (failed: Unbound value Tls.Config.client_of_sexp)
  • mehari.0.2 (failed: Unbound module Tls.Core.Cert)
  • jackline (failed: Unbound value Tls.Engine.string_of_failure)

hannesm added a commit to hannesm/opam-repository that referenced this pull request Mar 1, 2023
CHANGES:

* tls-async: remove ocaml < 5.0.0 constraint (mirleft/ocaml-tls#471 mirleft/ocaml-tls#474 @hannesm)
* remove dependency on ppx, especially ppx_cstruct and ppx_sexp_conv across
  the libraries (mirleft/ocaml-tls#473 @hannesm, discussion in mirleft/ocaml-tls#472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant