Skip to content
This repository has been archived by the owner on Jul 18, 2018. It is now read-only.

Commit

Permalink
Revert of Enable BrowserScheduler.RedirectHistoryService experiment o…
Browse files Browse the repository at this point in the history 
…n trunk. (patchset #7 id:140001 of https://codereview.chromium.org/2592813002/ )

Reason for revert:
Suspected culprit http://crbug.com/680698 and http://crbug.com/682219 per HistoryService tasks no longer being guaranteed to be flushed in ~HistoryService -- which BookmarksModel depends on.

Original issue's description:
> Enable BrowserScheduler.RedirectHistoryService experiment on trunk.
>
> BUG=661143
> Committed: https://crrev.com/4aa30591e0953da7e0c54ffdb91856e496d16b5f
> Cr-Commit-Position: refs/heads/master@{#440418}
>
> Reverted: https://crrev.com/2885403f92c9ab0a8769c2c41e859502da5a7e6f
> Cr-Commit-Position: refs/heads/master@{#440479}
> Cause of revert fixed in https://codereview.chromium.org/2611053003/.
>
> Review-Url: https://codereview.chromium.org/2592813002
> Cr-Commit-Position: refs/heads/master@{#441997}
> Committed: https://chromium.googlesource.com/chromium/src/+/344517411399fc467e5a6938e4793650729b3506

[email protected]
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=661143,680698,682219

Review-Url: https://codereview.chromium.org/2642253002
Cr-Commit-Position: refs/heads/master@{#444942}
  • Loading branch information
gab authored and Commit bot committed Jan 20, 2017
1 parent d5d9f82 commit 8f3596a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion testing/variations/fieldtrial_testing_config.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@
{
"name": "Default",
"params": {
"RedirectHistoryService": "true",
"RedirectSequencedWorkerPools": "true"
}
},
Expand Down

0 comments on commit 8f3596a

Please sign in to comment.