Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow global pipenv installation + let user install venv manually #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laermannjan
Copy link

Problem

  1. Currently, if you have python and pipenv in ~/.config/rtx/config.toml this plugin will create a pipenv venv in every directory you navigate to.

  2. If you configure your local .rtx.toml according to the readme, the automatic pipenv venv installation would pickup the globally available python, not the local one (I guess due to the parallel execution by rtx).

Suggested Fix

  1. skip pipenv setup when no Pipfile is found in current directory
  2. let the user install the pipenv venv manually after rtx has done its thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant