improve compress granularity through typeofs
#2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzc
reviewed
Jul 4, 2017
README.md
Outdated
| @@ -644,6 +644,9 @@ If you're using the `X-SourceMap` header instead, you can just omit `sourceMap.u | |||
| - `booleans` -- various optimizations for boolean context, for example `!!a | |||
| ? b : c → a ? b : c` | |||
|
|
|||
| - `typeofs` -- `typeof foo == "undefined"` → `foo === void 0` | |||
There was a problem hiding this comment.
typeofs-- defaulttrue. Transformstypeof foo == "undefined"intofoo === void 0.
There was a problem hiding this comment.
kzc
reviewed
Jul 4, 2017
README.md
Outdated
| @@ -644,6 +644,9 @@ If you're using the `X-SourceMap` header instead, you can just omit `sourceMap.u | |||
| - `booleans` -- various optimizations for boolean context, for example `!!a | |||
| ? b : c → a ? b : c` | |||
|
|
|||
| - `typeofs` -- `typeof foo == "undefined"` → `foo === void 0` | |||
| Note: Internet Explorer 10 or below has known issue with special values of `foo`. | |||
There was a problem hiding this comment.
Note: recommend to set this value to false for IE10 and earlier versions due to known issues.
There was a problem hiding this comment.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2198