Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11Y: Skin Tone Picker should be accessible #220

Closed
comp615 opened this issue Aug 17, 2018 · 1 comment · Fixed by #283
Closed

A11Y: Skin Tone Picker should be accessible #220

comp615 opened this issue Aug 17, 2018 · 1 comment · Fixed by #283

Comments

@comp615
Copy link

comp615 commented Aug 17, 2018

The Skin tone swatch in the preview bar should be accessible for both ARIA and keyboard navigation. This could be presented as a select menu or similar component.

nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Mar 9, 2019
@nolanlawson
Copy link

Starting to look into this. Seems the best design may be:

<button aria-haspopup="true" aria-expanded={!!opened}>
</button>

The challenge here is that the options are currently inside the button (which is a <div> currently). I think we'll have to change it so the HTML is outside of it, with role="menu"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants