Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steps to run the app locally + PR template #227

Closed
hozefaj opened this issue Aug 26, 2018 · 4 comments · Fixed by #276
Closed

steps to run the app locally + PR template #227

hozefaj opened this issue Aug 26, 2018 · 4 comments · Fixed by #276
Labels
documentation

Comments

@hozefaj
Copy link

hozefaj commented Aug 26, 2018

the Readme does not detail out steps to run the app locally. Also having some steps detailing on what's expected in a PR would be helpful.
@nolanlawson
Copy link

The docs are here, but you're right that they could be clearer: https://github.com/missive/emoji-mart#development

@hozefaj
Copy link
Author

hozefaj commented Mar 8, 2019

Will send PR

nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Mar 8, 2019
@nolanlawson
docs: add more explicit dev docs
e8b4cfd 
fixes missive#227
@nolanlawson nolanlawson mentioned this issue Mar 8, 2019
Merged
@nolanlawson
Copy link

Ah sorry, beat you to it. Please take a look and let me know if it covers everything! :)

@hozefaj
Copy link
Author

hozefaj commented Mar 8, 2019

Yeah look good to me 👍

@snyk-bot snyk-bot mentioned this issue Dec 12, 2019
Merged
This was referenced Sep 7, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add more explicit dev docs nolanlawson/emoji-mart
2 participants
@nolanlawson @hozefaj