Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #130

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Fix tests #130

merged 1 commit into from
Oct 6, 2017

Conversation

nolanlawson
Copy link

The tests are currently broken, but this PR fixes them.

  • Builds data to src/data/data.js
  • Checks the size-limit based on the slightly smaller dist-es/index.js

@nolanlawson
Copy link
Author

FWIW you might want to add Travis CI to catch these kinds of things in the future. 🙂

@EtienneLem
Copy link
Member

Definitely, thanks for doing that. Meant to do that right after merging your previous PR and release an update, but got caught up in work 😅

I also wanted to investigate the little size regression in dist, my guess was that it could be 81f39b1 but I’m not sure.

Will try to merge & release update ASAP.

@EtienneLem EtienneLem merged commit 9e81cc4 into missive:master Oct 6, 2017
@EtienneLem
Copy link
Member

Thanks again! Doing a release as we speak 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolanlawson @EtienneLem