Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Found Component for emoji search #206

Merged
merged 4 commits into from
Jul 30, 2018

Conversation

Rena-Ryumae
Copy link

If a user's search returns no results,
the sleuth_or_spy emoji appears. We would
instead like for a custom image to appear.

We propose creating a NotFound component
that uses the the sleuth_or_spy emoji
on default when a user's search returns
no results but otherwise uses what the
user passes through

Rena Ryumae and others added 4 commits July 13, 2018 13:58
If a user's search returns no results,
the sleuth_or_spy emoji appears. We would
instead like for a custom image to appear.

We propose creating a NotFound component
that uses the the sleuth_or_spy emoji
on default when a user's search returns
no results but otherwise uses what the
user passes through
@EtienneLem
Copy link
Member

Changes to note: I made it so when using a custom component, it doesn’t have the emoji-mart-no-results applied. That’s up to the developer to handle spacing / layout correctly when using a custom component.

As a bonus while in that area: I added a notFoundEmoji props to still use the default not found component, but a different emoji (default still is sleuth_or_spy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants