-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import compoments directly to avoid components/picker/index.js and have smaller bundle #245
Conversation
Probably related issue: #229 |
Interesting! I was under the impression that it was tree shaking’s job to be smart about these imports. |
Thanks 🤘 |
I think tree shaking is not possible with old Anyway, this is a super simple way to reduce bundle size with no tree shaking and other advanced things. No need to import a lot and strip useless code if we can just import what is needed. 😃 Thank you for merging, would be nice to see a new |
That’s my understanding as well, which is why we have 2 dist folders and specify the one with "main": "dist/index.js",
"module": "dist-es/index.js", But as far as I’m concerned we’ve been lied to… 😅
ETA few minutes 😄 |
Import all components directly, similar to #245
Amazing! Thank YOU 🤘 |
Those simple changes would allow importing Nimbleicker directly and avoid having all.json bundled when using apple.json or other emoji collections.