fix: add prop-types to dependencies #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
added a commit
to nolanlawson/emoji-mart
that referenced
this pull request
Mar 10, 2019
fix: add prop-types to dependencies
nolanlawson
added a commit
to nolanlawson/emoji-mart
that referenced
this pull request
Mar 10, 2019
fix: add prop-types to dependencies
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably a rude awakening for some people when they use
emoji-martand it complains thatprop-typesare missing. I checked our build output, and the only third-party libraries we require arereactandprop-types, butreactis already specified as apeerDependency.I looked to see how other React component libraries do it, and it seems react-virtualized uses a dependency, not a peerDependency, for prop-types. So it seems reasonable for us to do the same.