Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused notFoundString prop #288

Merged

Conversation

nolanlawson
Copy link

While playing with the storybook, I noticed a warning:

Warning: Failed prop type: The prop `notFoundString` is marked as required in `NotFound`, but its value is `undefined`.
    in NotFound (created by Category)
    in Category (created by NimblePicker)
    in div (created by NimblePicker)
    in div (created by NimblePicker)
    in NimblePicker (created by Picker)
    in Picker
    in WrapStory

This prop seems to be entirely unused, since this component actually uses i18n.notfound instead. I also can't find any documentation or any other references to it. It seems safe to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant