Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest emoji-datasource #78

Merged
merged 8 commits into from
May 27, 2017
Merged

Update to latest emoji-datasource #78

merged 8 commits into from
May 27, 2017

Conversation

savardc
Copy link

@savardc savardc commented May 15, 2017

Emoji 4 support through latest version of emoji-data

I switched the default sheetSize to 32px since the 64px is not part of the main package anymore

@EtienneLem
Copy link
Member

Been following and wanting to upgrade emoji-data for a while, but using the 32px file as the default will most likely make the emojis blurry.

That being said, we could still have the updated emoji-datasource as a dependency, but link to the right sub-package at https://github.com/missive/emoji-mart/blob/master/src/components/emoji.js#L129

What do you think?

@savardc
Copy link
Author

savardc commented May 17, 2017

I reverted the default sheetSize since the local version of emoji-datasource is not use for images (unless you have a backgroundImageFn)

@samkelleher
Copy link

This looks good to be merged? Seperatly I have a fork in which I am working on splitting out the emoji-data from this lib so it can be 'injected' rather than bundled. This is useful for me since my application uses the emoji-data lib elsewhere and don't want to bundle it twice.

@EtienneLem EtienneLem merged commit 04b993e into missive:master May 27, 2017
@EtienneLem
Copy link
Member

Looks good to me! Thanks 🤘

@savardc savardc deleted the emoji4 branch May 31, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants