Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

反応がなくなったwebsocketコネクションを切断する #10885

Closed
syuilo opened this issue May 24, 2023 · 0 comments
Closed

反応がなくなったwebsocketコネクションを切断する #10885

syuilo opened this issue May 24, 2023 · 0 comments
Assignees
@syuilo
Labels
🔥high priority packages/backend Server side specific issue/PR

Comments

@syuilo
Copy link
Member

syuilo commented May 24, 2023

Summary

実際は接続が切れてるけど切断判定されないコネクションが発生することがあるっぽく、それを放置するとメモリリークや負荷が増えると思われるため

https://github.com/websockets/ws#how-to-detect-and-close-broken-connections
@syuilo syuilo added the packages/backend Server side specific issue/PR label May 24, 2023
@syuilo syuilo self-assigned this May 24, 2023
@syuilo syuilo closed this as completed in 9eaca96 Jun 2, 2023
sasagar pushed a commit to sasagar/misskey that referenced this issue Jun 5, 2023
@syuilo @sasagar
perf(backend): terminate stalled websocket connections
7112c36 
Resolve misskey-dev#10885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syuilo syuilo

Labels
🔥high priority packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@syuilo