Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): リアクションできない問題をとりあえず修正 #10529

Merged
merged 2 commits into from
Apr 9, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Apr 8, 2023

Fix #10502

What

Redisから返ってきた値がArrayではない場合データベースから取ってくることでお茶をにごす

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@tamaina tamaina requested a review from syuilo April 8, 2023 14:37
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #10529 (17bada4) into develop (7bd0001) will decrease coverage by 3.56%.
The diff coverage is 68.03%.

❗ Current head 17bada4 differs from pull request most recent head 65e2f6b. Consider uploading reports for the commit 65e2f6b to get more accurate results

@@             Coverage Diff             @@
##           develop   #10529      +/-   ##
===========================================
- Coverage    78.59%   75.04%   -3.56%     
===========================================
  Files          161      885     +724     
  Lines        19647    87047   +67400     
  Branches       331     5880    +5549     
===========================================
+ Hits         15442    65323   +49881     
- Misses        4205    21724   +17519     
Impacted Files Coverage Δ
packages/backend/src/core/DeleteAccountService.ts 55.00% <ø> (ø)
packages/backend/src/core/GlobalEventService.ts 93.54% <ø> (ø)
...e/processors/ImportCustomEmojisProcessorService.ts 21.48% <0.00%> (ø)
...queue/processors/WebhookDeliverProcessorService.ts 25.00% <0.00%> (ø)
packages/backend/src/server/ServerService.ts 48.68% <0.00%> (ø)
.../src/server/api/endpoints/admin/accounts/delete.ts 59.09% <ø> (ø)
...ckend/src/server/api/endpoints/admin/emoji/copy.ts 65.68% <ø> (ø)
...end/src/server/api/endpoints/admin/suspend-user.ts 55.55% <ø> (ø)
...backend/src/server/api/endpoints/antennas/notes.ts 58.67% <0.00%> (ø)
...ackend/src/server/api/endpoints/channels/follow.ts 75.80% <ø> (ø)
... and 108 more

... and 619 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 9feb6b0 into misskey-dev:develop Apr 9, 2023
@syuilo
Copy link
Member

syuilo commented Apr 9, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't react with custom emoji リアクションできない
2 participants