Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): IdService.parseを全てのidタイプに対応させるように #10533

Merged
merged 3 commits into from
Apr 8, 2023

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Apr 8, 2023

Fix #10531

What

  • IdService.parseを完全にする
  • idのテストを書く

@github-actions github-actions bot added packages/backend Server side specific issue/PR 🧪Test labels Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #10533 (35d3927) into develop (7bd0001) will decrease coverage by 3.48%.
The diff coverage is 68.91%.

@@             Coverage Diff             @@
##           develop   #10533      +/-   ##
===========================================
- Coverage    78.59%   75.12%   -3.48%     
===========================================
  Files          161      886     +725     
  Lines        19647    87086   +67439     
  Branches       331     5907    +5576     
===========================================
+ Hits         15442    65420   +49978     
- Misses        4205    21666   +17461     
Impacted Files Coverage Δ
packages/backend/src/core/DeleteAccountService.ts 55.00% <ø> (ø)
packages/backend/src/core/GlobalEventService.ts 93.54% <ø> (ø)
...e/processors/ImportCustomEmojisProcessorService.ts 21.48% <0.00%> (ø)
...queue/processors/WebhookDeliverProcessorService.ts 25.00% <0.00%> (ø)
packages/backend/src/server/ServerService.ts 48.68% <0.00%> (ø)
.../src/server/api/endpoints/admin/accounts/delete.ts 59.09% <ø> (ø)
...ckend/src/server/api/endpoints/admin/emoji/copy.ts 65.68% <ø> (ø)
...end/src/server/api/endpoints/admin/suspend-user.ts 55.55% <ø> (ø)
...backend/src/server/api/endpoints/antennas/notes.ts 58.67% <0.00%> (ø)
...ackend/src/server/api/endpoints/channels/follow.ts 75.80% <ø> (ø)
... and 114 more

... and 615 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina tamaina changed the title wip fix-id fix(server): IdService.parseを全てのidタイプに対応させるように Apr 8, 2023
@tamaina tamaina requested a review from syuilo April 8, 2023 16:38
@tamaina
Copy link
Contributor Author

tamaina commented Apr 8, 2023

ready for review

@syuilo syuilo merged commit d76220c into misskey-dev:develop Apr 8, 2023
@syuilo
Copy link
Member

syuilo commented Apr 8, 2023

🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idがmeid, meidg, ulid, objectidの場合、チャンネルや通知がバグる
2 participants