Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sw: なんかもうめっちゃ変えた #10570

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Apr 10, 2023

What

  • 「通知が既読になったらプッシュ通知を削除する」の機能だけが殺されたのを復活させる(設定だけ残っていたが、設定を完全に消すのが面倒だったため機能を復活させることにした)
    • user_visible_auto_notification防止用の通知の挙動を変えた(hostをタイトルに・bodyにバージョンを埋め込み、削除はしないように)
  • プッシュ通知が実績を解除 (achievementEarned) に対応
  • notificationclickで既存のクライアントの投稿フォームを開く(order: post)際の挙動を修正
  • たくさんのプッシュ通知を閉じた際、その通知の数だけnotifications/mark-all-as-readを叩くのをやめるように

Why

プッシュ通知をいい感じにしたい

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #10570 (db4ec72) into develop (da64273) will increase coverage by 0.04%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop   #10570      +/-   ##
===========================================
+ Coverage    75.10%   75.14%   +0.04%     
===========================================
  Files          886      888       +2     
  Lines        87116    87281     +165     
  Branches      5906     5902       -4     
===========================================
+ Hits         65430    65591     +161     
- Misses       21686    21690       +4     
Impacted Files Coverage Δ
...ckages/backend/src/core/PushNotificationService.ts 38.31% <20.00%> (-0.90%) ⬇️
packages/backend/src/core/NotificationService.ts 93.67% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina
Copy link
Contributor Author

tamaina commented Apr 10, 2023

user_visible_auto_notification防止用の通知

Screenshot_20230411-005925.png

iconにインスタンスのアイコンを埋め込んでもよさそうな気もするが、iOSだと二重に表示されそうだし表示されるたびに/metaなどを取りに行きまくる感じになるので微妙そう

@tamaina tamaina changed the title sw: なんかめっちゃ変えた sw: なんかもうめっちゃ変えた Apr 10, 2023
@syuilo syuilo merged commit 3a90bcc into misskey-dev:develop Apr 11, 2023
@syuilo
Copy link
Member

syuilo commented Apr 11, 2023

🙏🏻

na2na-p pushed a commit to na2na-p/misskey that referenced this pull request Apr 11, 2023
* sw: なんかいろいろ

* remove debug code

* never renotify

* update changelog.md
hutchisr pushed a commit to hutchisr/misskey that referenced this pull request Apr 12, 2023
* sw: なんかいろいろ

* remove debug code

* never renotify

* update changelog.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants