Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): improve signup complete ui #10876

Merged
merged 5 commits into from
May 24, 2023

Conversation

caipira113
Copy link
Contributor

@caipira113 caipira113 commented May 20, 2023

What

Improved the ui of signup complete.

Why

I thought the new MkAnimBg would be more colorful and improved than before if I used it together.

Additional info (optional)

Actually, while contemplating the application of Zen UI, I made some modifications to main-boot.ts. If you happen to know a better method, I would appreciate it.

signup-complete
signup-complete.mp4

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #10876 (bab75f7) into develop (b0344e0) will increase coverage by 17.45%.
The diff coverage is n/a.

❗ Current head bab75f7 differs from pull request most recent head 3a46cec. Consider uploading reports for the commit 3a46cec to get more accurate results

@@             Coverage Diff              @@
##           develop   #10876       +/-   ##
============================================
+ Coverage    77.25%   94.71%   +17.45%     
============================================
  Files          740        2      -738     
  Lines        70372      454    -69918     
  Branches      6402       59     -6343     
============================================
- Hits         54369      430    -53939     
+ Misses       16003       24    -15979     

see 738 files with indirect coverage changes

@syuilo syuilo merged commit acdcd7c into misskey-dev:develop May 24, 2023
@syuilo
Copy link
Member

syuilo commented May 24, 2023

👍🏻👍🏻👍🏻

sasagar pushed a commit to sasagar/misskey that referenced this pull request Jun 5, 2023
* enhance(frontend): improve signup complete ui

* relocation

* tweak

* Update _boot_.ts

---------

Co-authored-by: syuilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants