Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): migrate bull to bullmq #10910

Merged
merged 13 commits into from
May 29, 2023
Merged

enhance(backend): migrate bull to bullmq #10910

merged 13 commits into from
May 29, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented May 28, 2023

What

Resolve #6221

Why

See #6221

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test packages/frontend Client side specific issue/PR labels May 28, 2023
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #10910 (2ebad11) into develop (fb54c58) will increase coverage by 0.08%.
The diff coverage is 68.56%.

@@             Coverage Diff             @@
##           develop   #10910      +/-   ##
===========================================
+ Coverage    77.25%   77.34%   +0.08%     
===========================================
  Files          740      740              
  Lines        70373    70409      +36     
  Branches      6402     6423      +21     
===========================================
+ Hits         54369    54459      +90     
+ Misses       16004    15950      -54     
Impacted Files Coverage Δ
packages/backend/src/config.ts 96.41% <0.00%> (ø)
packages/backend/src/core/CaptchaService.ts 27.90% <0.00%> (ø)
...s/backend/src/core/FetchInstanceMetadataService.ts 22.66% <0.00%> (ø)
...backend/src/core/activitypub/LdSignatureService.ts 26.75% <0.00%> (ø)
...ckend/src/server/api/endpoints/admin/relays/add.ts 89.04% <0.00%> (ø)
...nd/src/server/api/endpoints/notes/search-by-tag.ts 52.89% <0.00%> (ø)
...kages/backend/src/server/api/endpoints/reset-db.ts 84.44% <0.00%> (ø)
...e/processors/ExportCustomEmojisProcessorService.ts 28.36% <5.00%> (-0.21%) ⬇️
...kend/src/queue/processors/InboxProcessorService.ts 28.72% <6.66%> (-2.91%) ⬇️
...nd/src/queue/processors/DeliverProcessorService.ts 38.68% <25.00%> (+0.55%) ⬆️
... and 35 more

@syuilo
Copy link
Member Author

syuilo commented May 28, 2023

ERR Lua redis lib command arguments must be strings or integers script: 2eddb0e6d7479fa4b1e57e8d03beec511bc502ea, on @user_script:192.

@syuilo
Copy link
Member Author

syuilo commented May 28, 2023

ヌァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァァンンンンオオオオンンオンオンオンオンンンンンンンンン゛ン゛!!!!!!!!!!!!!!!!

@syuilo
Copy link
Member Author

syuilo commented May 28, 2023

テストは通った

@syuilo syuilo marked this pull request as ready for review May 28, 2023 11:41
@github-actions github-actions bot requested a review from EbiseLutica May 28, 2023 11:41
@tamaina
Copy link
Contributor

tamaina commented May 28, 2023

move e2eが通ってるなら完全に動作していると言って過言ではなさそう

@syuilo
Copy link
Member Author

syuilo commented May 28, 2023

マージするか

@syuilo
Copy link
Member Author

syuilo commented May 28, 2023

this.utilityService.extractDbHost is not a function

何もいじってないのに全く関係ないとこでエラー出てきた?

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

this.utilityService.extractDbHost is not a function

何もいじってないのに全く関係ないとこでエラー出てきた?

関係ないことはなかったけどなぜそうなるのかは謎

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

92ef167 時点では通ってるし

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

その後のコミットでバックエンドは変更してないのでなぜエラーが出るようになったのかも謎

@tamaina
Copy link
Contributor

tamaina commented May 29, 2023

f4dc7ad の意図は何?

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

f4dc7ad の意図は何?

簡単にエラーオブジェクトに置き換えられなそうだったのと、どこからも使われてなかったからとりあえずコメントアウトした
(よく見たらバックエンドだったわ、けどやっぱり関係はなさそう)

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

文字列throwをやめたのは、bull-mqだとその方法でのthrowは対応してないらしいからついでに全部書き換えた

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

どこからも使われてなかった

いや普通に使われてるかも

@tamaina
Copy link
Contributor

tamaina commented May 29, 2023

使われてる

@tamaina
Copy link
Contributor

tamaina commented May 29, 2023

そして普通に通った

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

@tamaina 🙏🏻🙏🏻🙏🏻

@syuilo syuilo merged commit fd7b77c into develop May 29, 2023
@syuilo syuilo deleted the bullmq branch May 29, 2023 02:54
@tamaina
Copy link
Contributor

tamaina commented May 29, 2023

連合も問題なさそう

@syuilo
Copy link
Member Author

syuilo commented May 29, 2023

Bull dashboardで良い感じに表示されるようになった
deliverの個々のジョブ名に宛先ホストが表示されるようにもなった

sasagar pushed a commit to sasagar/misskey that referenced this pull request Jun 5, 2023
* wip

* wip

* Update QueueService.ts

* wip

* refactor

* ✌️

* fix

* Update QueueStatsService.ts

* refactor

* Update ApNoteService.ts

* Update mock-resolver.ts

* refactor

* Update mock-resolver.ts
riku6460 added a commit to MisskeyIO/misskey that referenced this pull request Jun 14, 2023
riku6460 added a commit to MisskeyIO/misskey that referenced this pull request Jun 15, 2023
Revert "enhance(backend): migrate bull to bullmq (misskey-dev#10910)"
GrapeApple0 added a commit to GrapeApple0/misskey that referenced this pull request Jul 2, 2023
Steve-0628 pushed a commit to Steve-0628/misskey that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bullをbullmqに移行
2 participants