Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condensedlines reflow once #10944

Merged
merged 5 commits into from
Jun 5, 2023

Conversation

yuriha-chan
Copy link
Contributor

What

Fixes #10927
全てのMkCondensedLineオブジェクトでgetBoundingClientRectの読み出しが完了してからスタイルを書き換える

Why

better performance on page load / read more

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 2, 2023
@syuilo syuilo requested a review from acid-chicken June 3, 2023 00:01
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #10944 (9c7885c) into develop (a7abf94) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #10944      +/-   ##
===========================================
- Coverage    78.04%   78.02%   -0.02%     
===========================================
  Files          172      172              
  Lines        21446    21450       +4     
  Branches       498      498              
===========================================
  Hits         16737    16737              
- Misses        4709     4713       +4     
Impacted Files Coverage Δ
...frontend/src/components/global/MkCondensedLine.vue 81.15% <0.00%> (-5.00%) ⬇️

@syuilo syuilo merged commit 2d5bb40 into misskey-dev:develop Jun 5, 2023
@syuilo
Copy link
Member

syuilo commented Jun 5, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MkCondensedLineによるリフローを抑制する
3 participants