Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ApDeliverManagerService.tsの型とJSDocを適切に置き換え #11096

Merged
merged 5 commits into from
Jul 5, 2023
Merged

refactor: ApDeliverManagerService.tsの型とJSDocを適切に置き換え #11096

merged 5 commits into from
Jul 5, 2023
+13 −8

Conversation

Umisyo
Copy link
Contributor

@Umisyo Umisyo commented Jul 4, 2023 •
edited
Loading

What

  • ApDeliverManagerServiceからanyを削除
  • JSDocを実態に合わせて修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 4, 2023
@Umisyo Umisyo closed this Jul 4, 2023
@Umisyo Umisyo changed the title refactor: ApDeliverManagerService.tsの型とJSDoc refactor: ApDeliverManagerService.tsの型とJSDocを適切に置き換え Jul 4, 2023
@Umisyo Umisyo reopened this Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #11096 (fbc4da3) into develop (22227fa) will decrease coverage by 16.60%.
The diff coverage is 100.00%.

❗ Current head fbc4da3 differs from pull request most recent head 384112e. Consider uploading reports for the commit 384112e to get more accurate results

@@             Coverage Diff              @@
##           develop   #11096       +/-   ##
============================================
- Coverage    93.93%   77.33%   -16.60%     
============================================
  Files            2      907      +905     
  Lines          462    91491    +91029     
  Branches        59     7548     +7489     
============================================
+ Hits           434    70759    +70325     
- Misses          28    20732    +20704
Impacted Files Coverage Δ
...nd/src/core/activitypub/ApDeliverManagerService.ts 97.19% <100.00%> (ø)

... and 904 files with indirect coverage changes

@Umisyo Umisyo marked this pull request as draft July 4, 2023 06:29
@Umisyo Umisyo marked this pull request as ready for review July 4, 2023 06:45
@tamaina tamaina merged commit 8f94b36 into misskey-dev:develop Jul 5, 2023
9 of 10 checks passed
slofp pushed a commit to Secineralyr/misskey.dream that referenced this pull request Jul 21, 2023
@Umisyo @tamaina @slofp
refactor: ApDeliverManagerService.tsの型とJSDocを適切に置き換え (misskey-dev#11096)
664e929 
* refactor: ApDeliverManagerService.ts のanyを適切な型に置き換え

Signed-off-by: Umisyo <[email protected]>

* fix: quote to single quote

Signed-off-by: Umisyo <[email protected]>

* refactor: JSDocを実態に合わせて修正

Signed-off-by: Umisyo <[email protected]>

* fix: activityのnullを許容するよう変更

Signed-off-by: Umisyo <[email protected]>

---------

Signed-off-by: Umisyo <[email protected]>
Co-authored-by: tamaina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EbiseLutica EbiseLutica Awaiting requested review from EbiseLutica

@tamaina tamaina Awaiting requested review from tamaina

@acid-chicken acid-chicken Awaiting requested review from acid-chicken

Assignees
No one assigned
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Umisyo @tamaina