Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(backend): improve streaming api performance #12033

Merged
merged 7 commits into from
Oct 15, 2023
Merged

perf(backend): improve streaming api performance #12033

merged 7 commits into from
Oct 15, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Oct 14, 2023

What

ストリーミングAPIにおけるノート受信時の処理を効率化した

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (329830e) 79.27% compared to head (7b69f83) 79.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12033      +/-   ##
===========================================
+ Coverage    79.27%   79.31%   +0.03%     
===========================================
  Files          930      931       +1     
  Lines        99412    99461      +49     
  Branches      8084     8074      -10     
===========================================
+ Hits         78812    78886      +74     
+ Misses       20600    20575      -25     
Files Coverage Δ
packages/backend/src/core/NoteCreateService.ts 89.18% <100.00%> (ø)
...ges/backend/src/core/entities/NoteEntityService.ts 88.31% <100.00%> (+0.07%) ⬆️
.../src/server/api/stream/channels/global-timeline.ts 95.57% <60.00%> (+3.01%) ⬆️
...d/src/server/api/stream/channels/local-timeline.ts 95.53% <60.00%> (+0.53%) ⬆️
...ackend/src/server/api/stream/channels/user-list.ts 96.68% <81.81%> (+3.52%) ⬆️
...nd/src/server/api/stream/channels/home-timeline.ts 93.69% <66.66%> (+3.44%) ⬆️
.../src/server/api/stream/channels/hybrid-timeline.ts 95.34% <66.66%> (+4.56%) ⬆️
.../backend/src/server/api/stream/channels/channel.ts 32.53% <0.00%> (+2.85%) ⬆️
.../backend/src/server/api/stream/channels/hashtag.ts 31.81% <0.00%> (+0.70%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo marked this pull request as ready for review October 14, 2023 10:31
@syuilo syuilo merged commit 3f4ee98 into develop Oct 15, 2023
16 checks passed
@syuilo syuilo deleted the zqt branch October 15, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant