Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

開いてるページで投稿先がチャンネルになってほしい #12688

Conversation

fruitriin
Copy link
Contributor

What

開いているページ(mainRouter)がチャンネルのとき、そのチャンネルを投稿先にしたいです

2023-12-16.13.24.15.mov

Why

投稿ボタンが2つあって間違えるし、NとPのショートカットでチャンネルへ投稿できないので

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Comment on lines 610 to 614
...props,
// 本当はチャンネル名や色もほしいけどどっからとってこよう
channel: {
id: route[2]
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの処理についてはいい案があれば直してほしいです

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 16, 2023
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (67a41c0) 77.80% compared to head (f680469) 79.64%.

❗ Current head f680469 differs from pull request most recent head 3c36575. Consider uploading reports for the commit 3c36575 to get more accurate results

Files Patch % Lines
packages/frontend/src/os.ts 9.09% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12688      +/-   ##
===========================================
+ Coverage    77.80%   79.64%   +1.83%     
===========================================
  Files          182      955     +773     
  Lines        24134   107724   +83590     
  Branches       433     8350    +7917     
===========================================
+ Hits         18778    85797   +67019     
- Misses        5356    21927   +16571     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sayamame-beans
Copy link
Member

Related issues: #10762 #11344

@samunohito
Copy link
Member

lintのチェックに多数抵触しているようなので、なおしていただけると助かります 🙏

@fruitriin
Copy link
Contributor Author

🙏

@fruitriin
Copy link
Contributor Author

lint 落ちてるけどどこがだめなのかわからない
tasukete

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Dec 16, 2023

lint 落ちてるけどどこがだめなのかわからない

見たけどたしかにこれは謎

@fruitriin
Copy link
Contributor Author

fruitriin commented Dec 17, 2023

https://misskey.systems/ ためせます

@fruitriin
Copy link
Contributor Author

誰も触らないのでクローズしました
望む人は再開してください

@fruitriin fruitriin reopened this Jan 18, 2024
@fruitriin
Copy link
Contributor Author

@syuilo any ideas?

@kakkokari-gtyih
Copy link
Contributor

Lint落ちてるのだけなんとかしたらマージしてよさそう

@fruitriin
Copy link
Contributor Author

CIがめっちゃ落ちるので一旦Close(後継もできたし!)

@@ -24,6 +24,7 @@ import MkContextMenu from '@/components/MkContextMenu.vue';
import { MenuItem } from '@/types/menu.js';
import copyToClipboard from '@/scripts/copy-to-clipboard.js';
import { showMovedDialog } from '@/scripts/show-moved-dialog.js';
import { mainRouter } from '@/router.js';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router周りあまり理解していないのでアレなんですが、'@/router.js'じゃなくて'@/global/router/main.js'じゃないです?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants