Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): ActivityPub 周りで連合先から HTTP 429 Too Many Requests を受け取った際にジョブをリトライするように #12917

Merged
merged 3 commits into from
Jan 6, 2024

Conversation

riku6460
Copy link
Contributor

@riku6460 riku6460 commented Jan 5, 2024

What

ActivityPub 周りで連合先から HTTP 429 Too Many Requests を受け取った際にジョブをリトライするように

Why

レートリミットで429が返ってきた際に捨てられてほしくないと思うので

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d415fd2) 79.88% compared to head (2134578) 79.88%.

Files Patch % Lines
...ges/backend/src/core/activitypub/ApInboxService.ts 0.00% 6 Missing ⚠️
...ckend/src/core/activitypub/models/ApNoteService.ts 0.00% 1 Missing ⚠️
...nd/src/queue/processors/DeliverProcessorService.ts 0.00% 1 Missing ⚠️
...kend/src/queue/processors/InboxProcessorService.ts 0.00% 1 Missing ⚠️
...queue/processors/WebhookDeliverProcessorService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12917   +/-   ##
========================================
  Coverage    79.88%   79.88%           
========================================
  Files          956      956           
  Lines       109113   109117    +4     
  Branches      8419     8419           
========================================
+ Hits         87162    87167    +5     
+ Misses       21951    21950    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fruitriin
Copy link
Contributor

オフトピ: too Many request の場合、同じ宛先のキューを後ろ回しにできたりしたらいいなあ

@syuilo syuilo merged commit 24645e3 into misskey-dev:develop Jan 6, 2024
18 checks passed
@syuilo
Copy link
Member

syuilo commented Jan 6, 2024

🙏🏻 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants