fix(frontend): 周年の実績が閏年を考慮するように #13525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13525 +/- ##
============================================
+ Coverage 64.69% 77.67% +12.97%
============================================
Files 986 185 -801
Lines 110809 25025 -85784
Branches 5692 484 -5208
============================================
- Hits 71691 19438 -52253
+ Misses 37682 5580 -32102
+ Partials 1436 7 -1429 ☔ View full report in Codecov by Sentry. |
kakkokari-gtyih
commented
Mar 6, 2024
Comment on lines
+190
to
210
| const createdAt = new Date($i.createdAt); | ||
| const createdAtThreeYearsLater = new Date($i.createdAt); | ||
| createdAtThreeYearsLater.setFullYear(createdAtThreeYearsLater.getFullYear() + 3); | ||
| if (now >= createdAtThreeYearsLater) { | ||
| claimAchievement('passedSinceAccountCreated3'); | ||
| claimAchievement('passedSinceAccountCreated2'); | ||
| claimAchievement('passedSinceAccountCreated1'); | ||
| } else { | ||
| const createdAtTwoYearsLater = new Date($i.createdAt); | ||
| createdAtTwoYearsLater.setFullYear(createdAtTwoYearsLater.getFullYear() + 2); | ||
| if (now >= createdAtTwoYearsLater) { | ||
| claimAchievement('passedSinceAccountCreated2'); | ||
| claimAchievement('passedSinceAccountCreated1'); | ||
| } else { | ||
| const createdAtOneYearLater = new Date($i.createdAt); | ||
| createdAtOneYearLater.setFullYear(createdAtOneYearLater.getFullYear() + 1); | ||
| if (now >= createdAtOneYearLater) { | ||
| claimAchievement('passedSinceAccountCreated1'); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Dateを量産してしまいそうなので逆順で探知させるようにした（好みの問題）
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
月日の一致で周年を判定するように
Why
Fix #13524
Additional info (optional)
Checklist