Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): チャート生成時にinstance.isSuspendedが読まれてしまう問題の修正 #13951

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Jun 6, 2024

What

#13861 の変更に伴ってDB上からはinstanceに対してisSuspendedがなくなったが残っていたのでチャート生成時にエラーが出ていたので置き換えた

Why

参照できない旨のエラーが出ていたため

Additional info (optional)

インスタンス一覧での絞り込みが失敗する問題に関しては#13945 ですでに修正PRがあるので残り部分の修正

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (8f833d7) to head (122ac34).

Files Patch % Lines
...ckages/backend/src/core/chart/charts/federation.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13951      +/-   ##
===========================================
- Coverage    65.01%   64.91%   -0.10%     
===========================================
  Files          989      989              
  Lines       112995   112995              
  Branches      5790     5777      -13     
===========================================
- Hits         73460    73352     -108     
- Misses       38093    38201     +108     
  Partials      1442     1442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tai-cha tai-cha marked this pull request as ready for review June 6, 2024 11:20
@tai-cha tai-cha changed the title fix(backend): use sustensionState instead of isSuspended fix(backend): チャート生成時にinstance.isSuspendedが読まれてしまう問題の修正 Jun 6, 2024
@syuilo syuilo merged commit 0015786 into misskey-dev:develop Jun 7, 2024
28 checks passed
@syuilo
Copy link
Member

syuilo commented Jun 7, 2024

🙏

yunochi added a commit to serafuku/misskey that referenced this pull request Jun 13, 2024
anatawa12 pushed a commit to anatawa12/misskey that referenced this pull request Jun 20, 2024
…13951)

* fix(backend): use sustensionState instead of isSuspended

* Update CHANGELOG.md
adzukimame pushed a commit to adzukimame/misskey that referenced this pull request Jun 28, 2024
…13951)

* fix(backend): use sustensionState instead of isSuspended

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants