Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #14394

Merged
merged 1 commit into from
Aug 12, 2024
Merged

chore: fix some comments #14394

merged 1 commit into from
Aug 12, 2024

Conversation

timesince
Copy link
Contributor

What

fix some comments

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Signed-off-by: timesince <[email protected]>
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.70%. Comparing base (4d75786) to head (140218e).

Files Patch % Lines
packages/backend/src/core/NoteDeleteService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14394      +/-   ##
===========================================
+ Coverage    39.91%   41.70%   +1.78%     
===========================================
  Files         1545     1549       +4     
  Lines       190505   196555    +6050     
  Branches      2651     2736      +85     
===========================================
+ Hits         76039    81971    +5932     
- Misses      113905   114021     +116     
- Partials       561      563       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 41936c1 into misskey-dev:develop Aug 12, 2024
28 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 12, 2024

🙏🏻

LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants