Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 以前のpopupの呼び出し方を修正 #14421

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 17, 2024
@syuilo syuilo merged commit 4e0d570 into misskey-dev:develop Aug 17, 2024
9 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 17, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-popup-dispose-1 branch August 17, 2024 09:05
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 20.02%. Comparing base (c0de57c) to head (d16c77d).
Report is 2 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/flash/flash.vue 0.00% 4 Missing ⚠️
packages/frontend/src/pages/gallery/post.vue 0.00% 4 Missing ⚠️
packages/frontend/src/pages/page.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14421       +/-   ##
============================================
- Coverage    38.75%   20.02%   -18.73%     
============================================
  Files         1547      725      -822     
  Lines       190878   100466    -90412     
  Branches      3263     1052     -2211     
============================================
- Hits         73969    20121    -53848     
+ Misses      116310    79801    -36509     
+ Partials       599      544       -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants