Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): アイコンデコレーション管理画面にプレビューを追加 #14511

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

image

image

Why

Fix #14490

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Sep 6, 2024
@syuilo
Copy link
Member

syuilo commented Sep 6, 2024

展開の操作なしにプレビューが表示されているUIがよさそう

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 6, 2024

展開の操作なしにプレビューが表示されているUIがよさそう

MkFolderが使えなくなるので結構大規模な変更になるかも(プレビューが出るようにするのを優先するならとりあえずこれで行って後からさらに改修するのも手)

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.

Project coverage is 20.16%. Comparing base (3fe7e37) to head (8d21534).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/avatar-decorations.vue 0.00% 80 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14511      +/-   ##
===========================================
- Coverage    20.17%   20.16%   -0.02%     
===========================================
  Files          725      725              
  Lines       100502   100569      +67     
  Branches      1045     1045              
===========================================
  Hits         20279    20279              
- Misses       79681    79748      +67     
  Partials       542      542              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit f7398fa into misskey-dev:develop Sep 6, 2024
18 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 6, 2024

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the enh-14490 branch September 6, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
2 participants