Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/perf(backend): provide metadata statically #14601

Merged
merged 33 commits into from
Sep 22, 2024
Merged

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Sep 21, 2024

What

#14578

Why

See #14578

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 21, 2024
Copy link
Contributor

github-actions bot commented Sep 21, 2024

api.jsonの差分作成中にエラーが発生しました。詳細はWorkflowのログを確認してください。

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 52.13483% with 213 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (7640866) to head (699d54e).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/backend/src/server/web/ClientServerService.ts 0.00% 25 Missing ⚠️
...ackages/backend/src/server/api/SignupApiService.ts 5.88% 16 Missing ⚠️
packages/backend/src/core/EmailService.ts 21.05% 15 Missing ⚠️
packages/backend/src/core/NoteCreateService.ts 57.69% 11 Missing ⚠️
packages/backend/src/core/DriveService.ts 67.85% 9 Missing ⚠️
...ckages/backend/src/server/web/UrlPreviewService.ts 0.00% 8 Missing ⚠️
packages/backend/src/GlobalModule.ts 88.52% 7 Missing ⚠️
packages/backend/src/core/WebAuthnService.ts 57.14% 6 Missing ⚠️
...ackend/src/server/api/endpoints/notes/translate.ts 33.33% 6 Missing ⚠️
...ckages/backend/src/core/chart/charts/federation.ts 44.44% 5 Missing ⚠️
... and 33 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14601      +/-   ##
===========================================
- Coverage    41.47%   39.65%   -1.82%     
===========================================
  Files         1545     1541       -4     
  Lines       197907   192171    -5736     
  Branches      3595     2520    -1075     
===========================================
- Hits         82077    76207    -5870     
- Misses      115268   115400     +132     
- Partials       562      564       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member Author

syuilo commented Sep 21, 2024

思ってたよりパフォーマンス向上効果ありそうな感じがしている

@syuilo
Copy link
Member Author

syuilo commented Sep 21, 2024

あとサーバー設定の反映が一瞬で行われるようになった

@kakkokari-gtyih kakkokari-gtyih changed the title refactor/perf(backend): provide metadata staticly refactor/perf(backend): provide metadata statically Sep 21, 2024
@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

jestでどうmockすればいいのか分からん

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

overrideProvider(DI.meta).useFactory({ factory: () => meta })じゃダメっぽい

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

TASUKETE

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

factoryは一回だけ呼ばれるから参照を保ったままにしないとダメだ

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

@syuilo syuilo marked this pull request as ready for review September 22, 2024 01:27
@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

なぜかアンテナのe2eテストが失敗する

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

ゔわー

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

Cannot post because it contains prohibited words.

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

別のe2eテストの設定が残っている可能性があるけど、e2eテスト間ってDBリセットされなかったっけ

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

あーDBはリセットされるけどnestインスタンスは作り直されないのか

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

その設計自体見直した方が良さそうだけど何か応急処置を考える必要がある

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

TASUKETE

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

通った

@syuilo
Copy link
Member Author

syuilo commented Sep 22, 2024

マージするか

@syuilo syuilo merged commit 023fa30 into develop Sep 22, 2024
30 checks passed
@syuilo syuilo deleted the provide-meta branch September 22, 2024 03:53
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
* wip

* Update ReactionService.ts

* Update ApiCallService.ts

* Update timeline.ts

* Update GlobalModule.ts

* Update GlobalModule.ts

* Update NoteEntityService.ts

* wip

* wip

* wip

* Update ApPersonService.ts

* wip

* Update GlobalModule.ts

* Update mock-resolver.ts

* Update RoleService.ts

* Update activitypub.ts

* Update activitypub.ts

* Update activitypub.ts

* Update activitypub.ts

* Update activitypub.ts

* clean up

* Update utils.ts

* Update UtilityService.ts

* Revert "Update utils.ts"

This reverts commit a27d4be.

* Revert "Update UtilityService.ts"

This reverts commit e5fd9e0.

* vuwa-

* Revert "vuwa-"

This reverts commit 0c3bd12.

* Update entry.ts

* Update entry.ts

* Update entry.ts

* Update entry.ts

* Update jest.setup.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant