Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): prefix css variables (UI) #14739

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 17.85714% with 207 lines in your changes missing coverage. Please review.

Project coverage is 19.37%. Comparing base (a624546) to head (b430239).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/classic.vue 0.00% 9 Missing ⚠️
packages/frontend/src/ui/universal.vue 0.00% 9 Missing ⚠️
packages/frontend/src/ui/_common_/navbar.vue 0.00% 8 Missing ⚠️
packages/frontend/src/pages/timeline.vue 0.00% 7 Missing ⚠️
packages/frontend/src/pages/page.vue 0.00% 6 Missing ⚠️
packages/frontend/src/components/MkFolder.vue 0.00% 5 Missing ⚠️
packages/frontend/src/ui/_common_/common.vue 0.00% 5 Missing ⚠️
packages/frontend/src/components/MkPagePreview.vue 0.00% 4 Missing ⚠️
packages/frontend/src/pages/antenna-timeline.vue 0.00% 4 Missing ⚠️
packages/frontend/src/pages/avatar-decorations.vue 0.00% 4 Missing ⚠️
... and 87 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14739       +/-   ##
============================================
- Coverage    41.38%   19.37%   -22.01%     
============================================
  Files         1557      721      -836     
  Lines       200808   102316    -98492     
  Branches      3627      992     -2635     
============================================
- Hits         83101    19827    -63274     
+ Misses      117106    81938    -35168     
+ Partials       601      551       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Oct 10, 2024

単に MI でも良さそう

@kakkokari-gtyih
Copy link
Contributor Author

単に MI でも良さそう

トップレベルに置いたら他のMI要素とぶつかって後々面倒かなと思ったので

@syuilo
Copy link
Member

syuilo commented Oct 10, 2024

テーマ以外で使われるCSS変数でUIに関係しないものって(今も未来も)存在しない気がしたからそうするとわざわざUIを付けるのは冗長になる気がした感じ

@kakkokari-gtyih
Copy link
Contributor Author

テーマ以外で使われるCSS変数でUIに関係しないものって(今も未来も)存在しない気がした

なるほど、もどした

@kakkokari-gtyih
Copy link
Contributor Author

#14739 (review) #14739 (review) らへんがどういう想定だったかの確認ができたらreadyかも

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 10, 2024 06:10
@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Oct 10, 2024

カスタムCSSを利用している人が割と多いので、不本意だったとしてもCHANGELOGで言及しておいたほうが親切そう(別に減るもんではないし)

image

@syuilo syuilo merged commit b668d16 into misskey-dev:develop Oct 10, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 10, 2024

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the refactor-css-variables-ui branch October 10, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants