-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend): prefix css variables (UI) #14739
refactor(frontend): prefix css variables (UI) #14739
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14739 +/- ##
============================================
- Coverage 41.38% 19.37% -22.01%
============================================
Files 1557 721 -836
Lines 200808 102316 -98492
Branches 3627 992 -2635
============================================
- Hits 83101 19827 -63274
+ Misses 117106 81938 -35168
+ Partials 601 551 -50 ☔ View full report in Codecov by Sentry. |
単に MI でも良さそう |
トップレベルに置いたら他のMI要素とぶつかって後々面倒かなと思ったので |
テーマ以外で使われるCSS変数でUIに関係しないものって(今も未来も)存在しない気がしたからそうするとわざわざUIを付けるのは冗長になる気がした感じ |
なるほど、もどした |
#14739 (review) #14739 (review) らへんがどういう想定だったかの確認ができたらreadyかも |
🙏🏻 |
What
Why
Additional info (optional)
Checklist