test: e2eテストがCIで失敗していた問題をいくつか修正 #8642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございます！ |
あーすみませんfixって書いちゃってますね…一応私が見たことのあるエラーは潰したつもりで、１０回くらいワークフローを動かして通るか確認しましたが、すべて直っている自信は無いです |
|
見たことのあるエラーと対応する修正コミット
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
その２つはmochaのテストの修正で、このプルリクはcypressのe2eテストの修正です |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
ありがとうございます🙏🏻🙏🏻🙏🏻 |
atsu1125
pushed a commit
to sakura-tel/metaskey
that referenced
this pull request
Dec 7, 2022
* test: e2eテストがCIで失敗していた問題をいくつか修正 (misskey-dev#8642) * test: indexeddbをテスト毎に初期化するように * fix: metaが無いときにfetch-metaを同時に呼ぶと死ぬことがある問題を修正 * test: ログイン後のクライアント側処理を待たずにリロードされてログイン出来ないことがあったのを修正 * redisClient.FLUSHDB * TypeORM 0.2.x Co-authored-by: iwata <[email protected]> Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
#7986 が直ったかもしれない
Additional info (optional)