Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to a rupicola/bedrock2 where wp is complete wrt exec #1631

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

samuelgruetter
Copy link
Contributor

No description provided.

@andres-erbsen andres-erbsen mentioned this pull request Aug 7, 2023
(&,fe25519_from_bytes :: functions))
As fe25519_from_bytes_correct.
SuchThat (forall functions,
Interface.map.get functions "fe25519_from_bytes" = Some fe25519_from_bytes ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a way that a function works correctly without putting it in an environment (perhaps like WeakestPrecondition.call) but the current change is eh-okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, all our function specs are expressed in terms of WeakestPrecondition.call, which looks up the function to be called in the env, so we always have to add the hypothesis that it's in the env (which previously was also required, but in a less verbose way, by simply cons-ing it to the head of the functions list).
An alternative would be to say, all our function specs are expressed in terms of WeakestPrecondition.func (and probably, the prefix WeakestPrecondition should be changed to Semantics, then). That would mean, though, that spec_of instances already have to be able to refer to the implementation of the function being specified, so probably that's not what we want.
So for now, I don't see any immediately-obviously-good change to make right now, so, indeed, eh-okay 😅

@samuelgruetter samuelgruetter marked this pull request as ready for review August 14, 2023 19:53
@andres-erbsen andres-erbsen merged commit d0f0305 into mit-plv:master Aug 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants